Open
Bug 1467778
Opened 7 years ago
Updated 3 years ago
[ESLint] Fix DevTools eslint overrides for "max-len"
Categories
(DevTools :: General, enhancement)
Tracking
(Not tracked)
NEW
People
(Reporter: jdescottes, Unassigned)
References
(Blocks 1 open bug)
Details
"files": [
"client/framework/**",
"client/scratchpad/**",
"client/shared/*.jsm",
"client/shared/widgets/*.jsm",
"client/webide/**",
],
"rules": {
"max-len": "off",
}
Turn off the override above in https://searchfox.org/mozilla-central/source/devtools/.eslintrc.js and fix all the violations reported by eslint.
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Comment 1•3 years ago
|
||
There are no max-len rules in devtools/.eslintrc.js any more, they got removed in bug 1558517.
https://hg.mozilla.org/mozilla-central/rev/d8ba04c4c323b0bb6bdc6f5a4b1ac7853209e0e5#l9.1
I am trying to figure out when/why max-len enforcement started to be dropped. It looks like it was already globally off at least 4 years ago (bug 1541834).
|
|
||
Comment 2•3 years ago
|
||
I see, it's now covered by Prettier: https://searchfox.org/mozilla-central/rev/c1180ea13e73eb985a49b15c0d90e977a1aa919c/.prettierrc#3
But Prettier's printWidth option is not the same as eslint's max-len: https://prettier.io/docs/en/options.html#print-width
See Also: → prettier-format
You need to log in
before you can comment on or make changes to this bug.
Description
•